fix(UpdatePanel): add zip type to semver-based update checks - #2444

src/components/panels/Machine/UpdatePanel/Entry.vue (1)

274-274: Optional: extract the repeated semver-type guard into a computed property.

['python', 'web', 'zip'] is now spelled out four times in the script section. If a new semver-based type (e.g. pip) is added later, it's easy to update three of the four occurrences and silently miss one, causing a UI regression identical to the one this PR is fixing.

Extracting to a single computed getter eliminates that risk:

♻️ Proposed refactor — add `isSemverType` getter

+    get isSemverType() {
+        return ['python', 'web', 'zip'].includes(this.type)
+    }
+
     get btnDisabled() {
         if (['printing', 'paused'].includes(this.printer_state)) return true
         if (!this.isValid || this.isCorrupt || this.isDirty || this.commitsBehind.length) return false
 
-        if (['python', 'web', 'zip'].includes(this.type)) return !this.semverUpdatable
+        if (this.isSemverType) return !this.semverUpdatable
 
         return this.commitsBehind.length === 0
     }
 
     get btnIcon() {
         if (this.isDetached || !this.isValid || this.isCorrupt || this.isDirty) return mdiCloseCircle
 
-        if (['python', 'web', 'zip'].includes(this.type)) {
+        if (this.isSemverType) {
             if (this.semverUpdatable) return mdiProgressUpload
             else if (this.localVersion === null || this.remoteVersion === null) return mdiHelpCircleOutline
         }
         ...
     }
 
     get btnColor() {
         if (this.isCorrupt || this.isDetached || this.isDirty || !this.isValid) return 'orange'
 
-        if (['python', 'web', 'zip'].includes(this.type) && this.semverUpdatable) return 'primary'
+        if (this.isSemverType && this.semverUpdatable) return 'primary'
         ...
     }
 
     get btnText() {
         ...
-        if (['python', 'web', 'zip'].includes(this.type)) {
+        if (this.isSemverType) {
             if (this.semverUpdatable) return this.$t('Machine.UpdatePanel.Update')
             ...
         }
         ...
     }

The same guard can be applied in the template too:

-<template v-else-if="['web', 'zip'].includes(type) && semverUpdatable">
+<template v-else-if="isSemverType && type !== 'python' && semverUpdatable">

(Or keep the template inline — the template form is less critical since it's a single occurrence.)

Also applies to: 282-285, 295-295, 307-311

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/panels/Machine/UpdatePanel/Entry.vue` at line 274, The
repeated semver-type check (['python','web','zip']) is duplicated across the
Entry.vue script; add a computed getter named isSemverType that returns
['python','web','zip'].includes(this.type) and replace all inline checks
(currently used in the conditions around the semverUpdatable logic—e.g., the if
(['python','web','zip'].includes(this.type) ... usages) with this.isSemverType
so future types need updating in only one place; ensure the new getter is
exported in the component's computed block and update the template/other script
references to use isSemverType.